Fix multiple jscompiler errors#26632
Open
stephenduong1004 wants to merge 3 commits intoemscripten-core:mainfrom
Open
Fix multiple jscompiler errors#26632stephenduong1004 wants to merge 3 commits intoemscripten-core:mainfrom
stephenduong1004 wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
Apr 6, 2026
sbc100
reviewed
Apr 7, 2026
src/preamble.js
Outdated
| #if ASSERTIONS && !('$FS' in addedLibraryItems) | ||
| // show errors on likely calls to FS when it was not included | ||
| var FS = { | ||
| /** @return {*} */ |
Collaborator
There was a problem hiding this comment.
does @return {undefined} work here?
sbc100
reviewed
Apr 7, 2026
src/preamble.js
Outdated
| mkdev() { FS.error() }, | ||
| createLazyFile() { return (/** @type {?} */ (FS.error())); }, | ||
| open() { return (/** @type {?} */ (FS.error())); }, | ||
| mkdev() { return (/** @type {?} */ (FS.error())); }, |
Collaborator
There was a problem hiding this comment.
Do you know why the JS compiler if reporting Missing return statement here? Why is it expecting this method to return anything at all?
Collaborator
|
Does #26641 fix the FS errors? |
Will be fixed in emscripten-core#26641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following errors after #26424: